Fix for #2485 #2681
Closed
Fix for #2485 #2681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.1+ | Fixed tickets | 2485 Fixes the documented example of how to test forms with custom types, as there was no better suggestions than the one put forward by @chrisburgess7 I implemented that in my test case & it worked so I've updated the documentation to match.
|
Hi Stuart! Thanks for taking on this fix! What do you think about this approach instead: #2485 (comment). It seems truer to the intention of the change (e.g. Thanks! |
|
Hey Stuart! Someone has already fixed this with an approach similar to the one I just pointed out (#2725). I look forward to seeing other contributions from you soon! ;) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the documented example of how to test forms with custom types,
as there was no better suggestions than the one put forward by
@chrisburgess7 I implemented that in my test case & it worked so
I've updated the documentation to match.
(Resubmitted against the proper branch)