[Cookbook][Form testing] update sf2.3 way to add custom tupe #2724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Components][Console] Fixed typos for table helper
Made the Icu component compatible with ICU 3.8
Adding lazy services documentation as of symfony/symfony#7890
Conflicts: components/yaml/introduction.rst
Conflicts: components/yaml/introduction.rst
New in sf2.3, update the way we have to use to add custom Type.
|
you did a wrong rebase. Please do the change again for the 2.3 branch or rebase your current branch |
|
@wouterj sorry I don't understand, I select branch 2.3 as destination to merge my branch. I'm not familliar with PR, what I have to do? |
|
Well, you can do 2 things. If you're not familiar with git, the simplest is to go to the document you want to edit. Then select the correct branch from the dropdown box in the right corner just above the document. After you selected the 2.3 branch, you click on edit and do the changes, then request a PR and select the 2.3 branch from that branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2.3, we can't use anymore $this->factory->addType() t add custom Type to factory. We have to use PreloadedExtension class.