Skip to content

Conversation

garak
Copy link
Contributor

@garak garak commented Nov 1, 2013

E.g. changed "2.2" to "2.3" and so on

E.g. changed "2.2" to "2.3" and so on
@@ -13,7 +13,7 @@ Before contributing, you need to become familiar with the :doc:`markup
language <format>` used by the documentation.

The Symfony2 documentation is hosted on GitHub:

2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem to be correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you just added a random 2, didn't you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I didn't find a way to amend a commit made on github. Maybe it's better to close this PR and make a new one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget it, just found a way and edited my commit. Thank you!

@wouterj
Copy link
Member

wouterj commented Nov 2, 2013

+1, 2.2 reached eom this month. Let's wait til the last 2.2 release is done and then merge this.

Could you please also fix the README.md and CONTRIBUTING.md files?

@merk
Copy link
Contributor

merk commented Nov 2, 2013

@wouterj you mean 2.2 reached EOM this month yes?

@wouterj
Copy link
Member

wouterj commented Nov 2, 2013

@merk yes, indeed. Fixed now :)

@weaverryan
Copy link
Member

This and #3144 look ready to go, but I'm actually not sure exactly of Nov 2013 EOM means Nov 1st or Nov 30th :). I think there will be at least one more Symfony 2.2 release (since there are commits to that branch that aren't in a release yet), so I think we'll wait until towards the end of the month to official end maintenance on the 2.2 branch in the docs.

Thoughts?

@xabbuh
Copy link
Member

xabbuh commented Nov 7, 2013

👍 The EOM will be announced on the Symfony website, won't it?

@wouterj
Copy link
Member

wouterj commented Nov 7, 2013

Usually, it's mentioned in the last release. I already said in #3144 that I agree with @weaverryan point here :)

Symfony 2.4 is released at the end of this month, so I expect a 2.2.* release a week or so before that.

weaverryan added a commit that referenced this pull request Dec 8, 2013
Update references to current branch
@weaverryan weaverryan merged commit 305965d into symfony:2.3 Dec 8, 2013
@weaverryan
Copy link
Member

Thanks!

@garak garak deleted the patch-29 branch December 8, 2013 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy