Adding quotes to a server_version on an example just after explanation why are necessary #9815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just adding some quotes to server_version, couple of lines before is explained this: "Always wrap the server version number with quotes to parse it as a string instead of a float number"
|
Sergio, this was a very nice catch! Thanks for fixing it and congrats on your first Symfony Docs contribution! We've merged this on 2.7 branch because that's the oldest maintained branch that contains the bug ... and we'll merge it in the other branches automatically. |
javiereguiluz
added a commit
that referenced
this pull request
May 25, 2018
…r explanation why are necessary (sergiosusa) This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9815). Discussion ---------- Adding quotes to a server_version on an example just after explanation why are necessary just adding some quotes to server_version, couple of lines before is explained this: "Always wrap the server version number with quotes to parse it as a string instead of a float number" Commits ------- 3db34d4 Update doctrine.rst
|
thanks! @javiereguiluz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just adding some quotes to server_version, couple of lines before is explained this:
"Always wrap the server version number with quotes to parse it as a string instead of a float number"