Skip to content

add shape property #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2021
Merged

add shape property #178

merged 4 commits into from
Oct 16, 2021

Conversation

dev-mkc19
Copy link
Contributor

Adding ability to get shapes name from workbook

@dev-mkc19
Copy link
Contributor Author

@RussTheAerialist hello! I would like to being part of contributors by added some improvements. But my merge request is still opened. What should I do to speed up this process?

@jacalata
Copy link
Contributor

Hi @dev-mkc19 - sorry for the long silence. If you're still interested, could you add a test or a sample that shows your change working?

@jacalata jacalata changed the base branch from master to development June 7, 2021 22:20
@bcantoni
Copy link
Contributor

Confirmed we've received the CLA from @dev-mkc19, so we are all set on that part of this PR.

@dev-mkc19
Copy link
Contributor Author

@jacalata I added some tests and rebase my commits to be up to date, but think it wasn't good idea because some waste commits is included. What do you think?

@jacalata
Copy link
Contributor

jacalata commented Oct 6, 2021

I'm going to try rebasing this onto the dev branch, and that should get rid of all the unnecessary commits. If you would like to do that yourself then of course go ahead 😀

@dev-mkc19
Copy link
Contributor Author

No problem, I’ll do this. But I want to be sure that my work won’t be wasted, because 1,5 year for PR it’s crazy loooong.

@jacalata
Copy link
Contributor

jacalata commented Oct 7, 2021 via email

@dev-mkc19
Copy link
Contributor Author

dev-mkc19 commented Oct 16, 2021

@jacalata Just remember that I'm still waiting 😃

@jacalata
Copy link
Contributor

I remember!

@jacalata jacalata changed the base branch from development to jac/merge-mkc October 16, 2021 23:07
@jacalata jacalata merged commit ad90152 into tableau:jac/merge-mkc Oct 16, 2021
@jacalata
Copy link
Contributor

And there you go, 0.8 :) It'll go up on pypi during the week.

@dev-mkc19
Copy link
Contributor Author

Yeah, already saw the release. It's cool. Hope to be able to bring some more benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy