Updating development branch with publishing fixes #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 29, 2016 09:26
| @@ -0,0 +1,9 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
This won't work for a standard Windows world -- maybe that's ok but there are some cross platform options if we want to start adding build/test/doc scripts. A lot of projects use http://www.pyinvoke.org/ which is a rake-like system.
Not blocking, just a thought
There was a problem hiding this comment.
Good point @t8y8 though I'm hesitant to take a dependency on an external module just for making our job of pushing to pypi easier.
Eventually, I'd like to automate publishing to pypi when we create the release tag.
There was a problem hiding this comment.
Yeah, we probably won't hit the inflection point of needing something like that for a while.
Changes LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done originally on master to just make things easier, but needs to be brought into development.
This change also adds the publish.sh script used for publishing to pypi.