forked from bucardo/check_postgres
-
Notifications
You must be signed in to change notification settings - Fork 1
Merge Master #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cjestel
wants to merge
189
commits into
tdevelioglu:master
Choose a base branch
from
cjestel:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merge Master #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
action=sequence used to open a new session for every sequence checked, which could be very slow. Fix by creating a single SQL statement using UNION ALL to query all sequences at once.
The code was already there, but not covered by tests
Change the way tables are quoted in replicate_row to allow for tables with schema name.
check_sequence - Split big UNION of sequence selects into chunks to avoid overrunning system argument size run_command - If we have specified a "target" database, skip all others in global targetdb list
Newer versions will show the last or current query here, older versions will just show "<IDLE> in transaction" if there is currently no query running.
... and note author of last commit in changelog
set_translations.pl only wrote output for languages seen in .po files, dropping other previously known languages. Also, fix output to honor the current indentation style (no tabs). In order to change the current formatting as little as possible, set the minimal output key output width to 14, and no not append a space after 'key' ('checkcluster-nomrtg' is otherwise too long).
…eruser. The wrapper function around pg_ls_dir() must hardcode the pg_xlog or pgxlog/archive_status path, and should take no arguments. It must be created as a superuser with SECURITY DEFINER.
In https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790231, Daniel Schepler reports pbuilder (a throwaway-minimal-chroot build wrapper for Debian packages) to setup the filesystem name to be shown as "-". Allow this in the testsuite.
…ry the same-schema action will use to store its files.
The main PostgreSQL website is now https only. The versions.rss check still works by following the redirect, but it's more efficient to hit the https URL directly. In passing, also update all the direct links in the documentation to be https.
Update URLs to www.postgresql.org to be https
"make html" had not been run for some time, do that now.
This should fix GH Issue bucardo#139
make work with cascading replication
…mpty second value; loosen dbservie restrictions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed your branch was out of date with master. I merged that in and compared with upstream and all looks good. I can make a PR directly to upstream if you'd prefer. Thanks for merging in the other change and the initial work on this!
I'm not sure what the maintainers will want to see to incorporate this into a release, so I didn't want to go squashing commits and such.