Env config - make profile optional
#1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profile optional
|
Marking as draft until temporalio/sdk-core#968 is merged (will update core submodule after). This gives us default values for address and namespace |
No longer blocked (core PR closed). |
tconley1428
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
The
profileparameter is now optional, instead of defaulting to a value ofdefault.Why?
A defined
profilevalue is an explicit request for a specific profile in a provided configuration. Providing a default value made it impossible for a user to provide zero configuration (they would have to define adefaultprofile in their TOML).However, we want to allow users to provide zero configuration and have it default to
localhost:7233address anddefaultnamespace.This change makes that possible in combination with temporalio/sdk-core#968
How was this tested:
Existing integration tests
Any docs updates needed?
This change achieves parity with the docs