Skip to content

Add plugin to workflowenvironment #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025
Merged

Add plugin to workflowenvironment #1015

merged 3 commits into from
Aug 5, 2025

Conversation

tconley1428
Copy link
Contributor

What was changed

Why?

Came up as a question in #1009

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@tconley1428 tconley1428 requested a review from a team as a code owner July 31, 2025 17:41
@dandavison
Copy link
Contributor

Is there a way to get some coverage for this by using it in our own tests? E.g. somehow cleaning up this pattern?

async def test_some_test(client: Client):
    new_config = client.config()
    new_config["plugins"] = [
        openai_agents.OpenAIAgentsPlugin(
            model_params=ModelActivityParameters(
                start_to_close_timeout=timedelta(seconds=30)
            ),
            model_provider=CustomModelProvider(),
        )
    ]
    client = Client(**new_config)

@tconley1428
Copy link
Contributor Author

tconley1428 commented Aug 1, 2025

Is there a way to get some coverage for this by using it in our own tests? E.g. somehow cleaning up this pattern?

Potentially. I might have to understand more about pytest fixtures though, and it might be more difficult to see what is actually being validated. The same could theoretically be said for any other client modifications we do.

@tconley1428 tconley1428 merged commit b59c555 into main Aug 5, 2025
36 of 40 checks passed
@tconley1428 tconley1428 deleted the plugins/workflow_env branch August 5, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy