Nexus cancellation types #981
Open
+408
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aac8dcd to
d5039c2
Compare
d5039c2 to
134072e
Compare
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dandavison
added a commit
that referenced
this pull request
Aug 3, 2025
The test_cancellation_type tests were hanging indefinitely when run with the time-skipping environment, causing CI failures. These tests work fine with the regular environment but have compatibility issues with time-skipping, similar to other Nexus tests. Fixes the CI timeout failures seen on PR #981.
dandavison
added a commit
that referenced
this pull request
Aug 3, 2025
The test_cancellation_type tests were hanging indefinitely when run with the time-skipping environment, causing CI failures. These tests work fine with the regular environment but have compatibility issues with time-skipping, similar to other Nexus tests. Fixes the CI timeout failures seen on PR #981.
652f2b7 to
771aa96
Compare
aeb1b39 to
e1319f5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
c385c8a to
d58f06b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancellation types for Python Nexus. Does not expose
WAIT_REQUESTEDsince that requires furthersdk-corework. See temporalio/sdk-core#911 (comment)