Avoid crash in RequestActivityBuffer #97279
Merged
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9e3c91 to
e31414b
Compare
Activity tracing is currently not getting disabled for the CONCURRENT_KERNEL type due to a deadlock issue in CUDA 12.8+. This can lead to crashes during kernel execution after tracing has been disabled and the activity buffers have been destructed. The callbacks are still in place and will try to access the activity buffers during the next kernel execution. To avoid these crashes I'm adding this check for the existence of the activity buffers. PiperOrigin-RevId: 785722568
e31414b to
b662ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid crash in RequestActivityBuffer
Activity tracing is currently not getting disabled for the CONCURRENT_KERNEL type due to a deadlock issue in CUDA 12.8+.
This can lead to crashes during kernel execution after tracing has been disabled and the activity buffers have been destructed. The callbacks are still in place and will try to access the activity buffers during the next kernel execution.
To avoid these crashes I'm adding this check for the existence of the activity buffers.