Skip to content

[xla] ShapeUtil: avoid WithStatus callbacks on a hot path #97380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

[xla] ShapeUtil: avoid WithStatus callbacks on a hot path #97380

merged 1 commit into from
Jul 23, 2025

Conversation

copybara-service[bot]
Copy link

[xla] ShapeUtil: avoid WithStatus callbacks on a hot path

name                   cpu/op        cpu/op      vs base
BM_ShapeCount/0/0       4.892n ±  0%   4.554n ± 0%  -6.90% (p=0.000 n=20)
BM_ShapeCount/2/8       266.3n ±  0%   244.2n ± 1%  -8.30% (p=0.000 n=20)
BM_ShapeCount/4/8       23.43µ ± 14%   23.77µ ± 8%       ~ (p=0.989 n=20)
BM_ShapeCount/1/1000    3.271µ ±  1%   2.946µ ± 0%  -9.93% (p=0.000 n=20)
geomean                562.1n         528.3n       -6.02%

name                   time/op       time/op     vs base
BM_ShapeCount/0/0       4.903n ±  0%   4.564n ± 0%  -6.90% (p=0.000 n=20)
BM_ShapeCount/2/8       267.0n ±  0%   244.8n ± 1%  -8.30% (p=0.000 n=20)
BM_ShapeCount/4/8       23.49µ ± 14%   23.82µ ± 8%       ~ (p=0.968 n=20)
BM_ShapeCount/1/1000    3.279µ ±  1%   2.954µ ± 0%  -9.92% (p=0.000 n=20)
geomean                563.5n         529.6n       -6.03%

@copybara-service copybara-service bot force-pushed the exported_pr_786006030 branch from 1f0a92d to d3df8c1 Compare July 23, 2025 03:28
@ezhulenev @tensorflower-gardener
[xla] ShapeUtil: avoid WithStatus callbacks on a hot path
70b98e4 
```
name                   cpu/op        cpu/op      vs base
BM_ShapeCount/0/0       4.892n ±  0%   4.554n ± 0%  -6.90% (p=0.000 n=20)
BM_ShapeCount/2/8       266.3n ±  0%   244.2n ± 1%  -8.30% (p=0.000 n=20)
BM_ShapeCount/4/8       23.43µ ± 14%   23.77µ ± 8%       ~ (p=0.989 n=20)
BM_ShapeCount/1/1000    3.271µ ±  1%   2.946µ ± 0%  -9.93% (p=0.000 n=20)
geomean                562.1n         528.3n       -6.02%

name                   time/op       time/op     vs base
BM_ShapeCount/0/0       4.903n ±  0%   4.564n ± 0%  -6.90% (p=0.000 n=20)
BM_ShapeCount/2/8       267.0n ±  0%   244.8n ± 1%  -8.30% (p=0.000 n=20)
BM_ShapeCount/4/8       23.49µ ± 14%   23.82µ ± 8%       ~ (p=0.968 n=20)
BM_ShapeCount/1/1000    3.279µ ±  1%   2.954µ ± 0%  -9.92% (p=0.000 n=20)
geomean                563.5n         529.6n       -6.03%
```

PiperOrigin-RevId: 786116823
@copybara-service copybara-service bot force-pushed the exported_pr_786006030 branch from d3df8c1 to 70b98e4 Compare July 23, 2025 04:09
@copybara-service copybara-service bot merged commit 70b98e4 into master Jul 23, 2025
@copybara-service copybara-service bot deleted the exported_pr_786006030 branch July 23, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ezhulenev ezhulenev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ezhulenev
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy