Parse and ignore 'mode' attribute on collectives. #97392
Merged
+389
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f52f011 to
b15b9d0
Compare
The attribute was added and used in openxla/xla@cf3dfa9 but rolled back in openxla/xla@5542ebc since it broke TPU tests. However, HLO text generated between these two commits have the 'mode' attribute. So parse and ignore it for now to not break parsing such HLOs. In the future, once the TPU tests are fixed, the full commit will be rolled forward. Like in the original commit, I move the CollectiveOpGroupMode to it's own file to keep the parsing logic the same as the original commit. PiperOrigin-RevId: 786418187
b15b9d0 to
7f81be4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse and ignore 'mode' attribute on collectives.
The attribute was added and used in openxla/xla@cf3dfa9 but rolled back in openxla/xla@5542ebc since it broke TPU tests. However, HLO text generated between these two commits have the 'mode' attribute. So parse and ignore it for now to not break parsing such HLOs. In the future, once the TPU tests are fixed, the full commit will be rolled forward.
Like in the original commit, I move the CollectiveOpGroupMode to it's own file to keep the parsing logic the same as the original commit.