Fix: Clarify GPU compatibility check in TFLite Model Analyzer #97513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35cf465 to
3897cdc
Compare
This commit addresses the misleading output of the tool regarding GPU compatibility checks. - Adds a deprecation warning for the argument. - Modifies the output message to clearly state that GPU compatibility checks are skipped when the flag is enabled, as the feature is deprecated. Fixes: #77042 This commit addresses the misleading output of the tool regarding GPU compatibility checks. - Adds a deprecation warning for the argument. - Modifies the output message to clearly state that GPU compatibility checks are skipped when the flag is enabled, as the feature is deprecated. Fixes: #77042
3897cdc to
863b3d6
Compare
Comment on lines
+65
to
+66
| @deprecation.deprecated_arg_value( | ||
| None, "GPU compatibility check is deprecated.", "gpu_compatibility") |
There was a problem hiding this comment.
Umm, these need to be decided by the API owners, cannot just add deprecations randomly.
There was a problem hiding this comment.
Hi @mihaimaruseac, After reviewing the discussion in PR #74830 (comment), I realize the core issue is a confusing output message which appears to be generated in
I am happy to update this PR to address that output message instead of my current changes. Please let me know if you would prefer that or if I should close this PR because these need to be decided by the API owners. Thank you for your time.
There was a problem hiding this comment.
If it was deprecated then a deprecation message (from the decorator) is the best path forward, but still needs to go via approval of the API owners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Team
This addresses the misleading output of the TFLite Model Analyzer tool regarding GPU compatibility checks.