Skip to content

log.c Remove obsolete comment #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

joffman
Copy link
Contributor

@joffman joffman commented May 6, 2019

The comment for setup_logging was obsolete. The function
log_message() is called, fprintf() isn't.
This isn't a problem because of the send_stored_logs() function.

joffman added 5 commits May 5, 2019 10:24
This patch is related to parsing the filter file.
The new code skips leading whitespaces before removing trailing
whitespaces and comments.
Without doing this, lines with leading whitespace are treated like empty
lines (i.e. they are ignored).
Skipping leading whitespace and removing trailing whitespace and
comments were swapped to avoid skipping the leading whitespace twice.
I accidentally used tabs instead of spaces.
This commit fixes this.
The comment for setup_logging was obsolete. The function
log_message() is called, fprintf() isn't.
This isn't a problem because of the send_stored_logs() function.
@rofl0r
Copy link
Contributor

rofl0r commented Sep 7, 2020

@joffman could you redo your PR so there's only a single commit? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy