Skip to content

Fix for - Missing skills on user interface #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 9, 2020
Merged

Fix for - Missing skills on user interface #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
09a61a0
issue 3474 fix
rashmi73 Nov 27, 2019
06542d9
Update lookup.js
rashmi73 Dec 2, 2019
e164929
Update lookup.js
rashmi73 Dec 2, 2019
57d81ae
adding dev index
rashmi73 Dec 4, 2019
4d952f8
Update lookup.js
rashmi73 Dec 4, 2019
4b96064
Update lookup.js
rashmi73 Dec 4, 2019
8ebe97a
dev buid fix
rashmi73 Dec 4, 2019
7fdec8f
Merge pull request #114 from rashmi73/fix-tags-url-param
sushilshinde Dec 11, 2019
4a8bbdb
lint fix
rashmi73 Dec 11, 2019
933c5de
Merge pull request #117 from rashmi73/fix-tags-url-param
sushilshinde Dec 11, 2019
8639408
Added dist tag for test release
sushilshinde Dec 11, 2019
f3d1e44
Test releast npm ver bump up
sushilshinde Dec 11, 2019
f47d8cb
Merge remote-tracking branch 'origin/master' into hot-fixes-2
LieutenantRoger Feb 14, 2020
574391c
Merge pull request #128 from LieutenantRoger/hot-fixes-2
sushilshinde Feb 14, 2020
8b533e1
test release 1000.6.1
sushilshinde Feb 14, 2020
439212b
test npm bump up "version": "1000.6.2"
sushilshinde Feb 24, 2020
2944be1
Merge remote-tracking branch 'origin/develop' into hot-fixes-2
sushilshinde Mar 4, 2020
b19ae7d
Merge pull request #139 from topcoder-platform/hot-fixes-2
sushilshinde Mar 9, 2020
44e7dc5
release : fix for missing skills on user interface
sushilshinde Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@
},
"scripts": {
"build": "npm run clean && npm run build:dev && npm run build:prod",
"build:dev": "NODE_ENV=development ./node_modules/.bin/webpack --env=development --progress --profile --colors --display-optimization-bailout",
"build:dev": "./node_modules/.bin/webpack --env=development --progress --profile --colors --display-optimization-bailout",
"build:dev:watch": "npm run clean && ./node_modules/.bin/webpack --env=development --progress --profile --colors --watch --display-optimization-bailout",
"build:prod": "NODE_ENV=production ./node_modules/.bin/webpack --env=production --progress --profile --colors --display-optimization-bailout",
"build:prod": "./node_modules/.bin/webpack --env=production --progress --profile --colors --display-optimization-bailout",
"clean": "rimraf dist",
"jest": "jest --no-cache --maxWorkers=4 --config config/jest/default.js",
"lint": "npm run lint:js",
"lint:js": "./node_modules/.bin/eslint --ext .js,.jsx .",
"test": "npm run lint && npm run jest"
},
"version": "0.11.0",
"version": "0.11.1",
"dependencies": {
"auth0-js": "^6.8.4",
"config": "^3.2.0",
Expand Down
9 changes: 7 additions & 2 deletions src/actions/lookup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,13 @@ function getSkillTagsInit() {}
*/
function getSkillTagsDone() {
const params = {
domain: 'SKILLS',
status: 'APPROVED',
filter: {
domain: 'SKILLS',
status: 'APPROVED',
},
limit: {
limit: 1000,
},
};
return getService().getTags(params);
}
Expand Down
2 changes: 1 addition & 1 deletion src/services/lookup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class LookupService {
* @return {Promise} Resolves to the tags.
*/
async getTags(params) {
const res = await this.private.api.get(`/tags/?${qs.stringify(params)}`);
const res = await this.private.api.get(`/tags/?filter=${encodeURIComponent(qs.stringify(params.filter))}&${qs.stringify(params.limit)}`);
return getApiResponsePayload(res);
}

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy