-
Notifications
You must be signed in to change notification settings - Fork 48
biome: run from parent to fix silently broken plugin #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi! Thanks for the PR! Do you have a repro for this issue? I suspect |
Yes, it was noticed in this PR: freelensapp/freelens#874 You can get this commit after merge then remove settings from the .trunk.yaml and see the result: biome plugin silently ignores errors after you'll run If you say |
So it must be just
|
The problem is related to biomejs/biome#6662 which was not really fixed yet and decribed in biomejs/biome#6509 Biome sees the copy of working tree in sandbox as duplicated then refuses to work. My workaround is to use explicit I disabled cache as a first reason of the problem that it was for long time undetected. Biome is so fast that caching is not important. |
It addresses problems:
run_from: ${parent}
Now plugin breaks with the error:
With this setting biome correctly detects errors.
files: html
HTML file types are supported by Biome from 2.0 when enabled in configuration.