Add type hints #2971
Merged
Add type hints #2971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b880c6 to
388c629
Compare
stof
reviewed
Apr 23, 2019
| { | ||
| return []; | ||
| } | ||
|
|
||
| public function getNodeVisitors() | ||
| public function getNodeVisitors(): array |
There was a problem hiding this comment.
this will affect all extension authors, while they could already add it in older versions.
@nicolas-grekas is there any way to make Symfony's DebugClassLoader warn about future return types, similar to how you added support for future arguments ?
There was a problem hiding this comment.
cda3ac2 to
3c1d9e6
Compare
fabpot
added a commit
that referenced
this pull request
Apr 27, 2019
This PR was merged into the 3.x branch. Discussion ---------- [WIP] Add type hints Commits ------- 54cec4e added type hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.