Analyzer optimizations #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabff91 to
50ac753
Compare
|
Tests pass now. |
50ac753 to
b6d8094
Compare
frenchy64
reviewed
Jul 31, 2024
frenchy64
reviewed
Jul 31, 2024
frenchy64
reviewed
Jul 31, 2024
088d539 to
3d9a118
Compare
| @@ -500,10 +500,10 @@ | |||
| subset of methods that match best the given tags" | |||
| [tags methods] | |||
| (let [o-tags (mapv #(or (maybe-class %) Object) tags)] | |||
| (if-let [methods' (or (not-empty | |||
| (if-let [methods (or (not-empty | |||
There was a problem hiding this comment.
I've kept this because I didn't quite like the fact that if-let doesn't shadow if the value evaluates to falsey. Kinda confusing that methods refers to different things in then and else branches of the if-let.
There was a problem hiding this comment.
I'm more worried about accidentally using the old value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly trivial replacement of destructuring with explicit keyword getters in tighter places. Also, avoiding vararg assocs and updates.