Skip to content

Small analyzer optimizations #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions typed/clj.analyzer/src/typed/clj/analyzer/utils.cljc
Original file line number Diff line number Diff line change
Expand Up @@ -268,21 +268,22 @@

:default

(defn ^Class unbox
"If the argument is a Class with a primitive equivalent, returns that,
(do (def ^:private classes-with-primitives
{Integer Integer/TYPE,
Long Long/TYPE,
Float Float/TYPE,
Short Short/TYPE,
Boolean Boolean/TYPE,
Byte Byte/TYPE,
Character Character/TYPE,
Double Double/TYPE,
Void Void/TYPE})

(defn ^Class unbox
"If the argument is a Class with a primitive equivalent, returns that,
otherwise returns the argument"
[c]
({Integer Integer/TYPE,
Long Long/TYPE,
Float Float/TYPE,
Short Short/TYPE,
Boolean Boolean/TYPE,
Byte Byte/TYPE,
Character Character/TYPE,
Double Double/TYPE,
Void Void/TYPE}
c c))
)
[c]
(classes-with-primitives c c))))

(defn numeric?
"Returns true if the given class is numeric"
Expand Down
13 changes: 8 additions & 5 deletions typed/cljc.analyzer/src/typed/cljc/analyzer/utils.cljc
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,8 @@

(defn- -source-info-into-transient!
"Like `-source-info`, but returns a raw transient."
[x env dest]
(let [t (->> dest
(source-info-into-transient! env)
(source-info-into-transient! (meta x)))]
[x dest]
(let [t (source-info-into-transient! (meta x) dest)]
(if-let [file (let [file #?(:cljs cljs-ana/*cljs-file*
:default *file*)]
(and (not= file "NO_SOURCE_FILE")
Expand All @@ -217,7 +215,12 @@
(defn -source-info
"Returns the source-info of x"
([x env] (-source-info x env {}))
([x env base] (persistent! (-source-info-into-transient! x env (transient base)))))
([x env base]
(persistent! (if (identical? env base)
(-source-info-into-transient! x (transient base))
(->> (transient base)
(source-info-into-transient! env)
(-source-info-into-transient! x))))))

(defn const-val
"Returns the value of a constant node (either :quote or :const)"
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy