-
-
Notifications
You must be signed in to change notification settings - Fork 25
feat: allow using version ranges to cope with stale Maven Local cache #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
...in/io/github/typesafegithub/workflows/actionbindinggenerator/domain/SignificantVersion.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package io.github.typesafegithub.workflows.actionbindinggenerator.domain | ||
|
|
||
| /** | ||
| * The version part that is significant when generating the YAML output. | ||
| * This is used to enable usage of Maven ranges without needing to specify a custom version | ||
| * each time instantiating an action. | ||
| */ | ||
| public enum class SignificantVersion { | ||
| /** | ||
| * Only write the major version to the generated YAML. | ||
| */ | ||
| MAJOR, | ||
|
|
||
| /** | ||
| * Only write the major and minor version to the generated YAML. | ||
| */ | ||
| MINOR, | ||
|
|
||
| /** | ||
| * Write the full version to the generated YAML. | ||
| */ | ||
| FULL, | ||
| ; | ||
|
|
||
| override fun toString(): String = super.toString().lowercase() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
...kflows/actionbindinggenerator/bindingsfromunittests/ActionWithNoInputsWithMajorVersion.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // This file was generated using action-binding-generator. Don't change it by hand, otherwise your | ||
| // changes will be overwritten with the next binding code regeneration. | ||
| // See https://github.com/typesafegithub/github-workflows-kt for more info. | ||
| @file:Suppress( | ||
| "DataClassPrivateConstructor", | ||
| "UNUSED_PARAMETER", | ||
| ) | ||
|
|
||
| package io.github.typesafegithub.workflows.actions.johnsmith | ||
|
|
||
| import io.github.typesafegithub.workflows.domain.actions.Action | ||
| import io.github.typesafegithub.workflows.domain.actions.RegularAction | ||
| import java.util.LinkedHashMap | ||
| import kotlin.ExposedCopyVisibility | ||
| import kotlin.String | ||
| import kotlin.Suppress | ||
| import kotlin.Unit | ||
| import kotlin.collections.Map | ||
|
|
||
| /** | ||
| * Action: Action With No Inputs | ||
| * | ||
| * Description | ||
| * | ||
| * [Action on GitHub](https://github.com/john-smith/action-with-no-inputs-with-major-version) | ||
| * | ||
| * @param _customInputs Type-unsafe map where you can put any inputs that are not yet supported by the binding | ||
| * @param _customVersion Allows overriding action's version, for example to use a specific minor version, or a newer version that the binding doesn't yet know about | ||
| */ | ||
| @ExposedCopyVisibility | ||
| public data class ActionWithNoInputsWithMajorVersion private constructor( | ||
| /** | ||
| * Type-unsafe map where you can put any inputs that are not yet supported by the binding | ||
| */ | ||
| public val _customInputs: Map<String, String> = mapOf(), | ||
| /** | ||
| * Allows overriding action's version, for example to use a specific minor version, or a newer version that the binding doesn't yet know about | ||
| */ | ||
| public val _customVersion: String? = null, | ||
| ) : RegularAction<Action.Outputs>("john-smith", "action-with-no-inputs-with-major-version", _customVersion ?: "v3") { | ||
| public constructor( | ||
| vararg pleaseUseNamedArguments: Unit, | ||
| _customInputs: Map<String, String> = mapOf(), | ||
| _customVersion: String? = null, | ||
| ) : this(_customInputs = _customInputs, _customVersion = _customVersion) | ||
|
|
||
| @Suppress("SpreadOperator") | ||
| override fun toYamlArguments(): LinkedHashMap<String, String> = LinkedHashMap(_customInputs) | ||
|
|
||
| override fun buildOutputObject(stepId: String): Action.Outputs = Outputs(stepId) | ||
| } |
76 changes: 76 additions & 0 deletions
76
...ctionbindinggenerator/bindingsfromunittests/ActionWithNoInputsWithMajorVersion_Untyped.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| // This file was generated using action-binding-generator. Don't change it by hand, otherwise your | ||
| // changes will be overwritten with the next binding code regeneration. | ||
| // See https://github.com/typesafegithub/github-workflows-kt for more info. | ||
| @file:Suppress( | ||
| "DataClassPrivateConstructor", | ||
| "UNUSED_PARAMETER", | ||
| ) | ||
|
|
||
| package io.github.typesafegithub.workflows.actions.johnsmith | ||
|
|
||
| import io.github.typesafegithub.workflows.domain.actions.Action | ||
| import io.github.typesafegithub.workflows.domain.actions.RegularAction | ||
| import java.util.LinkedHashMap | ||
| import kotlin.Deprecated | ||
| import kotlin.ExposedCopyVisibility | ||
| import kotlin.String | ||
| import kotlin.Suppress | ||
| import kotlin.Unit | ||
| import kotlin.collections.Map | ||
|
|
||
| /** | ||
| * ```text | ||
| * !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| * !!! WARNING !!! | ||
| * !!! !!! | ||
| * !!! This action binding has no typings provided. All inputs will !!! | ||
| * !!! have a default type of String. !!! | ||
| * !!! To be able to use this action in a type-safe way, ask the !!! | ||
| * !!! action's owner to provide the typings using !!! | ||
| * !!! !!! | ||
| * !!! https://github.com/typesafegithub/github-actions-typing !!! | ||
| * !!! !!! | ||
| * !!! or if it's impossible, contribute typings to a community-driven !!! | ||
| * !!! !!! | ||
| * !!! https://github.com/typesafegithub/github-actions-typing-catalog !!! | ||
| * !!! !!! | ||
| * !!! This '_Untyped' binding will be available even once the typings !!! | ||
| * !!! are added. !!! | ||
| * !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| * ``` | ||
| * | ||
| * Action: Action With No Inputs | ||
| * | ||
| * Description | ||
| * | ||
| * [Action on GitHub](https://github.com/john-smith/action-with-no-inputs-with-major-version) | ||
| * | ||
| * @param _customInputs Type-unsafe map where you can put any inputs that are not yet supported by the binding | ||
| * @param _customVersion Allows overriding action's version, for example to use a specific minor version, or a newer version that the binding doesn't yet know about | ||
| */ | ||
| @Deprecated( | ||
| "Use the typed class instead", | ||
| ReplaceWith("ActionWithNoInputsWithMajorVersion"), | ||
| ) | ||
| @ExposedCopyVisibility | ||
| public data class ActionWithNoInputsWithMajorVersion_Untyped private constructor( | ||
| /** | ||
| * Type-unsafe map where you can put any inputs that are not yet supported by the binding | ||
| */ | ||
| public val _customInputs: Map<String, String> = mapOf(), | ||
| /** | ||
| * Allows overriding action's version, for example to use a specific minor version, or a newer version that the binding doesn't yet know about | ||
| */ | ||
| public val _customVersion: String? = null, | ||
| ) : RegularAction<Action.Outputs>("john-smith", "action-with-no-inputs-with-major-version", _customVersion ?: "v3") { | ||
| public constructor( | ||
| vararg pleaseUseNamedArguments: Unit, | ||
| _customInputs: Map<String, String> = mapOf(), | ||
| _customVersion: String? = null, | ||
| ) : this(_customInputs = _customInputs, _customVersion = _customVersion) | ||
|
|
||
| @Suppress("SpreadOperator") | ||
| override fun toYamlArguments(): LinkedHashMap<String, String> = LinkedHashMap(_customInputs) | ||
|
|
||
| override fun buildOutputObject(stepId: String): Action.Outputs = Outputs(stepId) | ||
| } |
51 changes: 51 additions & 0 deletions
51
...kflows/actionbindinggenerator/bindingsfromunittests/ActionWithNoInputsWithMinorVersion.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // This file was generated using action-binding-generator. Don't change it by hand, otherwise your | ||
| // changes will be overwritten with the next binding code regeneration. | ||
| // See https://github.com/typesafegithub/github-workflows-kt for more info. | ||
| @file:Suppress( | ||
| "DataClassPrivateConstructor", | ||
| "UNUSED_PARAMETER", | ||
| ) | ||
|
|
||
| package io.github.typesafegithub.workflows.actions.johnsmith | ||
|
|
||
| import io.github.typesafegithub.workflows.domain.actions.Action | ||
| import io.github.typesafegithub.workflows.domain.actions.RegularAction | ||
| import java.util.LinkedHashMap | ||
| import kotlin.ExposedCopyVisibility | ||
| import kotlin.String | ||
| import kotlin.Suppress | ||
| import kotlin.Unit | ||
| import kotlin.collections.Map | ||
|
|
||
| /** | ||
| * Action: Action With No Inputs | ||
| * | ||
| * Description | ||
| * | ||
| * [Action on GitHub](https://github.com/john-smith/action-with-no-inputs-with-minor-version) | ||
| * | ||
| * @param _customInputs Type-unsafe map where you can put any inputs that are not yet supported by the binding | ||
| * @param _customVersion Allows overriding action's version, for example to use a specific minor version, or a newer version that the binding doesn't yet know about | ||
| */ | ||
| @ExposedCopyVisibility | ||
| public data class ActionWithNoInputsWithMinorVersion private constructor( | ||
| /** | ||
| * Type-unsafe map where you can put any inputs that are not yet supported by the binding | ||
| */ | ||
| public val _customInputs: Map<String, String> = mapOf(), | ||
| /** | ||
| * Allows overriding action's version, for example to use a specific minor version, or a newer version that the binding doesn't yet know about | ||
| */ | ||
| public val _customVersion: String? = null, | ||
| ) : RegularAction<Action.Outputs>("john-smith", "action-with-no-inputs-with-minor-version", _customVersion ?: "v3.1") { | ||
| public constructor( | ||
| vararg pleaseUseNamedArguments: Unit, | ||
| _customInputs: Map<String, String> = mapOf(), | ||
| _customVersion: String? = null, | ||
| ) : this(_customInputs = _customInputs, _customVersion = _customVersion) | ||
|
|
||
| @Suppress("SpreadOperator") | ||
| override fun toYamlArguments(): LinkedHashMap<String, String> = LinkedHashMap(_customInputs) | ||
|
|
||
| override fun buildOutputObject(stepId: String): Action.Outputs = Outputs(stepId) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.