fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType #23310
ci.yml
on: pull_request
Checkout and Install
28s
Matrix: Run Unit Tests
Matrix: Lint with build
Run integration tests on primary Node.js version
1m 42s
Generate Configs
38s
Matrix: Run Unit Tests with Project Service
Upload Codecov Coverage
0s
Publish the latest code as a canary version
0s
Annotations
49 errors
|
Run integration tests on primary Node.js version
Process completed with exit code 1.
|
|
tests/flat-config-types-@types__eslint-v9.test.ts > flat-config-types-@types__eslint-v9 > eslint > should work successfully:
packages/integration-tests/tools/integration-test-base.ts#L62
AssertionError: expected '[@stylistic/eslint-plugin]: You are u…' to have a length of +0 but got 115
- Expected
+ Received
- 0
+ 115
❯ tools/integration-test-base.ts:62:20
❯ tools/integration-test-base.ts:21:9
|
|
Run Unit Tests (ubuntu-latest, 20, ast-spec)
Process completed with exit code 1.
|
|
tests/fixtures.test.ts > AST Fixtures > legacy-fixtures > basics > typed-this > AST Alignment - Token:
packages/ast-spec/tests/fixtures.test.ts#L342
Error: Snapshot `AST Fixtures > legacy-fixtures > basics > typed-this > AST Alignment - Token 1` mismatched
- Expected
+ Received
@@ -86,14 +86,12 @@
loc: {
start: { column: 28, line: 4 },
end: { column: 29, line: 4 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
+ Identifier {
- + type: 'Identifier',
+ type: 'Identifier',
value: 'this',
range: [124, 128],
loc: {
start: { column: 29, line: 4 },
❯ tests/fixtures.test.ts:342:11
|
|
tests/fixtures.test.ts > AST Fixtures > legacy-fixtures > basics > typed-this > TSESTree - Tokens:
packages/ast-spec/tests/fixtures.test.ts#L267
Error: Snapshot `AST Fixtures > legacy-fixtures > basics > typed-this > TSESTree - Tokens 1` mismatched
- Expected
+ Received
@@ -77,12 +77,12 @@
loc: {
start: { column: 28, line: 4 },
end: { column: 29, line: 4 },
},
},
- Keyword {
+ Identifier {
- type: "Keyword",
+ type: "Identifier",
value: "this",
range: [124, 128],
loc: {
start: { column: 29, line: 4 },
❯ tests/fixtures.test.ts:267:11
|
|
tests/fixtures.test.ts > AST Fixtures > legacy-fixtures > types > function-with-this > AST Alignment - Token:
packages/ast-spec/tests/fixtures.test.ts#L342
Error: Snapshot `AST Fixtures > legacy-fixtures > types > function-with-this > AST Alignment - Token 1` mismatched
- Expected
+ Received
@@ -46,14 +46,12 @@
loc: {
start: { column: 7, line: 3 },
end: { column: 8, line: 3 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
+ Identifier {
- + type: 'Identifier',
+ type: 'Identifier',
value: 'this',
range: [81, 85],
loc: {
start: { column: 8, line: 3 },
❯ tests/fixtures.test.ts:342:11
|
|
tests/fixtures.test.ts > AST Fixtures > legacy-fixtures > types > function-with-this > TSESTree - Tokens:
packages/ast-spec/tests/fixtures.test.ts#L267
Error: Snapshot `AST Fixtures > legacy-fixtures > types > function-with-this > TSESTree - Tokens 1` mismatched
- Expected
+ Received
@@ -37,12 +37,12 @@
loc: {
start: { column: 7, line: 3 },
end: { column: 8, line: 3 },
},
},
- Keyword {
+ Identifier {
- type: "Keyword",
+ type: "Identifier",
value: "this",
range: [81, 85],
loc: {
start: { column: 8, line: 3 },
❯ tests/fixtures.test.ts:267:11
|
|
tests/fixtures.test.ts > AST Fixtures > legacy-fixtures > types > this-type-expanded > AST Alignment - Token:
packages/ast-spec/tests/fixtures.test.ts#L342
Error: Snapshot `AST Fixtures > legacy-fixtures > types > this-type-expanded > AST Alignment - Token 1` mismatched
- Expected
+ Received
@@ -118,14 +118,12 @@
loc: {
start: { column: 15, line: 6 },
end: { column: 16, line: 6 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
- + type: 'Identifier',
+ Identifier {
+ type: 'Identifier',
value: 'this',
range: [120, 124],
loc: {
start: { column: 16, line: 6 },
@@ -282,14 +280,12 @@
loc: {
start: { column: 16, line: 10 },
end: { column: 17, line: 10 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
- + type: 'Identifier',
+ Identifier {
+ type: 'Identifier',
value: 'this',
range: [183, 187],
loc: {
start: { column: 17, line: 10 },
@@ -446,14 +442,12 @@
loc: {
start: { column: 16, line: 14 },
end: { column: 17, line: 14 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
- + type: 'Identifier',
+ Identifier {
+ type: 'Identifier',
value: 'this',
range: [241, 245],
loc: {
start: { column: 17, line: 14 },
@@ -710,14 +704,12 @@
loc: {
start: { column: 16, line: 19 },
end: { column: 17, line: 19 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
- + type: 'Identifier',
+ Identifier {
+ type: 'Identifier',
value: 'this',
range: [329, 333],
loc: {
start: { column: 17, line: 19 },
@@ -972,14 +964,12 @@
loc: {
start: { column: 21, line: 24 },
end: { column: 22, line: 24 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
- + type: 'Identifier',
+ Identifier {
+ type: 'Identifier',
value: 'this',
range: [419, 423],
loc: {
start: { column: 22, line: 24 },
@@ -1114,14 +1104,12 @@
loc: {
start: { column: 2, line: 28 },
end: { column: 8, line: 28 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
- + type: 'Identifier',
+ Identifier {
+ type: 'Identifier',
value: 'typeof',
range: [471, 477],
loc: {
start: { column: 9, line: 28 },
@@ -1136,14 +1124,12 @@
loc: {
start: { column: 15, line: 28 },
end: { column: 16, line: 28 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
- + type: 'Identifier',
+ Identifier {
+ type: 'Identifier',
value: 'this',
range: [478, 482],
loc: {
start: { column: 16, line: 28 },
❯ tests/fixtures.test.ts:342:11
|
|
tests/fixtures.test.ts > AST Fixtures > legacy-fixtures > types > this-type-expanded > TSESTree - Tokens:
packages/ast-spec/tests/fixtures.test.ts#L267
Error: Snapshot `AST Fixtures > legacy-fixtures > types > this-type-expanded > TSESTree - Tokens 1` mismatched
- Expected
+ Received
@@ -107,12 +107,12 @@
loc: {
start: { column: 15, line: 6 },
end: { column: 16, line: 6 },
},
},
- Keyword {
- type: "Keyword",
+ Identifier {
+ type: "Identifier",
value: "this",
range: [120, 124],
loc: {
start: { column: 16, line: 6 },
@@ -267,12 +267,12 @@
loc: {
start: { column: 16, line: 10 },
end: { column: 17, line: 10 },
},
},
- Keyword {
- type: "Keyword",
+ Identifier {
+ type: "Identifier",
value: "this",
range: [183, 187],
loc: {
start: { column: 17, line: 10 },
@@ -427,12 +427,12 @@
loc: {
start: { column: 16, line: 14 },
end: { column: 17, line: 14 },
},
},
- Keyword {
- type: "Keyword",
+ Identifier {
+ type: "Identifier",
value: "this",
range: [241, 245],
loc: {
start: { column: 17, line: 14 },
@@ -687,12 +687,12 @@
loc: {
start: { column: 16, line: 19 },
end: { column: 17, line: 19 },
},
},
- Keyword {
- type: "Keyword",
+ Identifier {
+ type: "Identifier",
value: "this",
range: [329, 333],
loc: {
start: { column: 17, line: 19 },
@@ -947,12 +947,12 @@
loc: {
start: { column: 21, line: 24 },
end: { column: 22, line: 24 },
},
},
- Keyword {
- type: "Keyword",
+ Identifier {
+ type: "Identifier",
value: "this",
range: [419, 423],
loc: {
start: { column: 22, line: 24 },
@@ -1087,12 +1087,12 @@
loc: {
start: { column: 2, line: 28 },
end: { column: 8, line: 28 },
},
},
- Keyword {
- type: "Keyword",
+ Identifier {
+ type: "Identifier",
value: "typeof",
range: [471, 477],
loc: {
start: { column: 9, line: 28 },
@@ -1107,12 +1107,12 @@
loc: {
start: { column: 15, line: 28 },
end: { column: 16, line: 28 },
},
},
- Keyword {
- type: "Keyword",
+ Identifier {
+ type: "Identifier",
value: "this",
range: [478, 482],
loc: {
start: { column: 16, line: 28 },
❯ tests/fixtures.test.ts:267:11
|
|
tests/fixtures.test.ts > AST Fixtures > legacy-fixtures > types > typeof-this > AST Alignment - Token:
packages/ast-spec/tests/fixtures.test.ts#L342
Error: Snapshot `AST Fixtures > legacy-fixtures > types > typeof-this > AST Alignment - Token 1` mismatched
- Expected
+ Received
@@ -46,14 +46,12 @@
loc: {
start: { column: 10, line: 3 },
end: { column: 16, line: 3 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
+ Identifier {
- + type: 'Identifier',
+ type: 'Identifier',
value: 'this',
range: [90, 94],
loc: {
start: { column: 17, line: 3 },
@@ -110,14 +108,12 @@
loc: {
start: { column: 9, line: 4 },
end: { column: 15, line: 4 },
},
},
- - Keyword {
- - type: 'Keyword',
- + Identifier {
+ Identifier {
- + type: 'Identifier',
+ type: 'Identifier',
value: 'this',
range: [112, 116],
loc: {
start: { column: 16, line: 4 },
❯ tests/fixtures.test.ts:342:11
|
|
tests/fixtures.test.ts > AST Fixtures > legacy-fixtures > types > typeof-this > TSESTree - Tokens:
packages/ast-spec/tests/fixtures.test.ts#L267
Error: Snapshot `AST Fixtures > legacy-fixtures > types > typeof-this > TSESTree - Tokens 1` mismatched
- Expected
+ Received
@@ -37,12 +37,12 @@
loc: {
start: { column: 10, line: 3 },
end: { column: 16, line: 3 },
},
},
- Keyword {
+ Identifier {
- type: "Keyword",
+ type: "Identifier",
value: "this",
range: [90, 94],
loc: {
start: { column: 17, line: 3 },
@@ -97,12 +97,12 @@
loc: {
start: { column: 9, line: 4 },
end: { column: 15, line: 4 },
},
},
- Keyword {
+ Identifier {
- type: "Keyword",
+ type: "Identifier",
value: "this",
range: [112, 116],
loc: {
start: { column: 16, line: 4 },
❯ tests/fixtures.test.ts:267:11
|
|
Run Unit Tests (ubuntu-latest, 18, eslint-plugin-internal)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 18, ast-spec)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 20, project-service)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 18, project-service)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 18, type-utils)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 20, scope-manager)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 20, rule-tester)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, visitor-keys)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 20, visitor-keys)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 20, tsconfig-utils)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, rule-tester)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, utils)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, parser)
The operation was canceled.
|
|
Run Unit Tests (windows-latest, 20, parser)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, tsconfig-utils)
The operation was canceled.
|
|
Run Unit Tests (windows-latest, 20, tsconfig-utils)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 20, type-utils)
The operation was canceled.
|
|
Run Unit Tests (ubuntu-latest, 20, type-utils)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, ast-spec)
The operation was canceled.
|
|
Run Unit Tests (windows-latest, 20, ast-spec)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, eslint-plugin)
The operation was canceled.
|
|
Run Unit Tests (windows-latest, 20, eslint-plugin)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, eslint-plugin-internal)
The operation was canceled.
|
|
Run Unit Tests (windows-latest, 20, eslint-plugin-internal)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, project-service)
The operation was canceled.
|
|
Run Unit Tests (windows-latest, 20, project-service)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, scope-manager)
The operation was canceled.
|
|
Run Unit Tests (windows-latest, 20, scope-manager)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, type-utils)
The operation was canceled.
|
|
Run Unit Tests (windows-latest, 20, type-utils)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, typescript-estree)
The operation was canceled.
|
|
Run Unit Tests (windows-latest, 20, typescript-estree)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (windows-latest, 20, typescript-eslint)
The operation was canceled.
|
|
Run Unit Tests (windows-latest, 20, typescript-eslint)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 20, eslint-plugin)
The operation was canceled.
|
|
Run Unit Tests (ubuntu-latest, 20, eslint-plugin)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
|
Run Unit Tests (ubuntu-latest, 18, eslint-plugin)
The operation was canceled.
|
|
Run Unit Tests (ubuntu-latest, 18, eslint-plugin)
The strategy configuration was canceled because "unit_tests.ubuntu-latest_20_ast-spec" failed
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
eslint-plugin-internal-coverage
Expired
|
4.34 KB |
sha256:557afc11f4816dce05c2fa82830a3c630b74e7e7c7e5fa8843dd18ff58ff0f97
|
|
|
parser-coverage
Expired
|
805 Bytes |
sha256:6af7f0eb6e27256cf3b78741cdb46ca91f608ac4f2e5a5ad6630a84a629695b1
|
|
|
typescript-eslint-coverage
Expired
|
1.16 KB |
sha256:96de952d23bd2f524540bc4abc72994921b413da51b7c5b94785bbc2e4e27d9b
|
|
|
typescript-estree-coverage
Expired
|
25.2 KB |
sha256:b81b9c8436d58948e097f83dcb5c2e96a68593241458ebb0c34cf23b5de2f581
|
|
|
utils-coverage
Expired
|
2.08 KB |
sha256:ec3b16ff024af23445561301246f40dbd532d8261405d569e95ff9b391085486
|
|