Bug: [dot-notation] Conflict between noPropertyAccessFromIndexSignature and extra (constrained) object keys #10627
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I have searched for related issues and found none that matched my issue.
- I have read the FAQ and my problem is not listed.
Playground Link
Repro Code
type ExtraKey = `extra${string}`;
type StructureWithExtras = {
foo: string;
bar: boolean;
[extraKey: ExtraKey]: number;
}
const structureWithExtras: StructureWithExtras = {
foo: "hello",
bar: false,
extraAbc: 42,
extraDef: 42,
}
console.log(structureWithExtras.foo)
console.log(structureWithExtras.bar)
console.log(structureWithExtras.extraAbc)
console.log(structureWithExtras.extraDef)
console.log(structureWithExtras["extraAbc"])
console.log(structureWithExtras["extraDef"])ESLint Config
module.exports = {
parser: "@typescript-eslint/parser",
rules: {
"@typescript-eslint/dot-notation": "error",
},
};tsconfig
Expected Result
I expected structureWithExtras["extraAbc"] to not produce ["extraAbc"] is better written in dot notation
Actual Result
structureWithExtras.extraAbcis not liked bytscstructureWithExtras["extraAbc"]is not liked by@typescript-eslint/dot-notation
Additional Info
Just using Record<ExtraKey, number> produces the same deadlock (Playground):
type ExtraKey = `extra${string}`;
type StructureWithJustExtras = Record<ExtraKey, number>;
const structureWithJustExtras: StructureWithJustExtras = {
extraAbc: 42,
extraDef: 42,
};
console.log(structureWithJustExtras.extraAbc);
console.log(structureWithJustExtras.extraDef);
console.log(structureWithJustExtras["extraAbc"]);
console.log(structureWithJustExtras["extraDef"]);Replacing Record<ExtraKey, number> with Record<string, number> helps (Playground):
type StructureWithStringKeys = Record<string, number>;
const structureWithStringKeys: StructureWithStringKeys = {
extraAbc: 42,
extraDef: 42,
};
console.log(structureWithStringKeys.extraAbc);
console.log(structureWithStringKeys.extraDef);
console.log(structureWithStringKeys["extraAbc"]);
console.log(structureWithStringKeys["extraDef"]);However, using Record<string, number> would not be possible in the original example where number value is used alongside string and boolean.
{ "compilerOptions": { "noPropertyAccessFromIndexSignature": true } }