Skip to content

Bug: Hidden (dot) directories aren't globbed in typescript-estree's projects globs #6306

@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Issue Description

When parserOptions.project includes a * wildcard, the call to globby doesn't include dot: true.

globSync([...globProjects, ...ignoreListInput], {
cwd: tsconfigRootDir,
}),

That means directories like .test won't have TSConfigs inside them found.

From this projects list:

project: [
  './examples/*/tsconfig.json',
  './examples/*/*/tsconfig.json',
  './packages/*/tsconfig.json',
  './tsconfig.eslint.json',
],

...and tsconfig.jsons at:

./examples/.test/ssg/tsconfig.json
./packages/next/tsconfig.json
./packages/react-query/tsconfig.json
./packages/server/tsconfig.json
./packages/client/tsconfig.json
./tsconfig.json
./tsconfig.eslint.json
/Users/josh/repos/repros/examples/.test/ssg/src/utils/trpc.ts
  0:0  error  Parsing error: ESLint was configured to run on `<tsconfigRootDir>/examples/.test/ssg/src/utils/trpc.ts` using `parserOptions.project`: 
- <tsconfigRootDir>/../../../../users/josh/repos/repros/tsconfig.eslint.json
- <tsconfigRootDir>/../../../../users/josh/repos/repros/packages/client/tsconfig.json
- <tsconfigRootDir>/../../../../users/josh/repos/repros/packages/next/tsconfig.json
- <tsconfigRootDir>/../../../../users/josh/repos/repros/packages/react-query/tsconfig.json
- <tsconfigRootDir>/../../../../users/josh/repos/repros/packages/server/tsconfig.json

We can see this in the wild with trpc/trpc#3390. Which is running out of memory in CI 🙃 but you can repro locally at trpc/trpc@3de2e91.

Reproduction Repository Link

https://github.com/JoshuaKGoldberg/repros/tree/b9f06eed94237ebd5a2180988f3ca084b2b6ad5c

Repro Steps

  1. clone the repo
  2. pnpm install
  3. pnpm lint

Alternately, running pnpm lint from examples/.test/ssg runs faster and also shows the issues.

Versions

package version
@typescript-eslint/eslint-plugin 5.48.0
@typescript-eslint/parser 5.48.0
@typescript-eslint/scope-manager 5.48.0
@typescript-eslint/typescript-estree 5.48.0
@typescript-eslint/type-utils 5.48.0
@typescript-eslint/utils 5.48.0
TypeScript 4.8.3
ESLint 8.30.0
node 18.7.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: typescript-estreeIssues related to @typescript-eslint/typescript-estree

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy