Skip to content

Repo: End-to-end test that no console errors are logged on the homepage #6354

@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Suggestion

Coming over from #6350: we had an issue with our React code caused by us using invalid HTML. Specifically, React was logging this:

Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.

We should end-to-end test to make sure this doesn't happen on the homepage again. Right now we just test that the homepage has no accessibility issues detectable by aXe:

test('Index', async ({ page }) => {
await page.goto('/');
await new AxeBuilder({ page }).analyze();
});

Playwright is able to listen to console messages. I propose we make a second end-to-end test that checks to make sure no console.error calls happened.

It wouldn't surprise me if a library already exists for Playwright somewhere that does this...

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuegood first issueGood for newcomersrepo maintenancethings to do with maintenance of the repo, and not with code/docs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy