Skip to content

Base rule extension: [prefer-promise-reject-errors] #7687

@DetachHead

Description

@DetachHead

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • My proposal specifically checks TypeScript syntax, or it proposes a check that requires type information to be accurate.
  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the base rule

https://eslint.org/docs/latest/rules/prefer-promise-reject-errors

Description

the prefer-promise-reject-errors rule should be extended as the base rule does not catch cases where the value is not a literal

Fail

const foo = "asdf"
Promise.reject(foo) // no error

Pass

const foo = new Error("asdf")
Promise.reject(foo) // no error

Additional Info

originally raised #7673 and eslint/eslint#17592 for no-throw-literal because i wasn't aware there was already a base rule for this

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issueenhancement: new base rule extensionNew base rule extension required to handle a TS specific casepackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy