-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Open
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issueenhancementNew feature or requestNew feature or requestpackage: rule-testerIssues related to the @typescript-eslint/rule-tester packageIssues related to the @typescript-eslint/rule-tester package
Description
Suggestion
We should add an extra type-checking step to rule-tester when testing type-aware lint rules. Right now, we have some test cases that don't pass, most notably because they have undeclared variables (which become any
). However we don't guarantee linting behavior when there are type errors (because the result is likely any
, which either created new lint errors or masks actual lint errors). Such type errors may be hard to catch in more complex situations.
Brad mentioned there may be a perf penalty, but it would be useful to experiment nonetheless.
kirkwaiblinger and ronami
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issueenhancementNew feature or requestNew feature or requestpackage: rule-testerIssues related to the @typescript-eslint/rule-tester packageIssues related to the @typescript-eslint/rule-tester package