Skip to content

Bug: [prefer-find] Add support for checking ternaries #8379

@kirkwaiblinger

Description

@kirkwaiblinger

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://main--typescript-eslint.netlify.app/rules/prefer-find

Description

This addresses a minor omission when I did the PR for this rule (#8216).

I forgot to add support for checking ternary branches. I've made a quick branch that would add support. See aa43ec6

Fail

(Math.random < 0.5 ? [1, 2, 3].filter(x => x % 2 === 0) : [4, 5, 6].filter(x => x % 2 === 0))[0]

Pass

Math.random < 0.5 ? [1, 2, 3].find(x => x % 2 === 0) : [4, 5, 6].find(x => x % 2 === 0)

Additional Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy