Skip to content

docs: give release time in UTC and local time #10823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

We on the maintenance team are spread around the world, so are our users, and our release automations don't respect DST, so let's just use UTC and call it a day?

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fe21e08
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67ae8bc3a80fe00008d08132
😎 Deploy Preview https://deploy-preview-10823--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Feb 10, 2025

View your CI Pipeline Execution ↗ for commit fe21e08.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 5s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-14 16:05:50 UTC

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg yes thank you I keep forgetting about this 🤦

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Feb 11, 2025
@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Feb 13, 2025
@kirkwaiblinger kirkwaiblinger changed the title docs: give release time in UTC docs: give release time in UTC and local time Feb 13, 2025
const formatted = date.toLocaleTimeString('en-US', {
hour: 'numeric',
minute: '2-digit',
timeZoneName: 'short',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not:

Suggested change
timeZoneName: 'short',
timeZoneName: 'short',
weekday: date.getDay() !== date.getUTCDay() ? 'long' : undefined,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it flows much more naturally to say "We release a latest version every Monday at 17:00 UTC (Tuesdays at 2:00 AM GMT+9)" than "We release a latest version every Monday at 17:00 UTC (Tuesday, 2:00 AM GMT+9)"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to put my words into code rather than let the code's default output speak for me haha

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Feb 14, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit ca89c34 into typescript-eslint:main Feb 17, 2025
62 of 63 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2025
@kirkwaiblinger kirkwaiblinger deleted the switch-release-time-to-utc branch March 6, 2025 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy