-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: give release time in UTC and local time #10823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: give release time in UTC and local time #10823
Conversation
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
View your CI Pipeline Execution ↗ for commit fe21e08.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg yes thank you I keep forgetting about this 🤦
const formatted = date.toLocaleTimeString('en-US', { | ||
hour: 'numeric', | ||
minute: '2-digit', | ||
timeZoneName: 'short', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not:
timeZoneName: 'short', | |
timeZoneName: 'short', | |
weekday: date.getDay() !== date.getUTCDay() ? 'long' : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it flows much more naturally to say "We release a latest version every Monday at 17:00 UTC (Tuesdays at 2:00 AM GMT+9)" than "We release a latest version every Monday at 17:00 UTC (Tuesday, 2:00 AM GMT+9)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to put my words into code rather than let the code's default output speak for me haha
ca89c34
into
typescript-eslint:main
PR Checklist
Overview
We on the maintenance team are spread around the world, so are our users, and our release automations don't respect DST, so let's just use UTC and call it a day?