Skip to content

chore(types): fix outDir in tsconfig.tools.json #10942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2025
Merged

chore(types): fix outDir in tsconfig.tools.json #10942

merged 3 commits into from
Mar 14, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 12, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3d7ba12
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67d46572cfa7ff0008d147da
😎 Deploy Preview https://deploy-preview-10942--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 79 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 12, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3d7ba12.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 7m 45s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 17s View ↗
nx test typescript-estree ✅ Succeeded 1m 13s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 6m 30s View ↗
nx test typescript-eslint ✅ Succeeded 10s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 1m 2s View ↗
nx test visitor-keys ✅ Succeeded 3s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-14 17:38:10 UTC

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 🙂

@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) March 14, 2025 17:20
@kirkwaiblinger kirkwaiblinger merged commit f07bdcf into typescript-eslint:main Mar 14, 2025
53 of 56 checks passed
@aryaemami59 aryaemami59 deleted the chore/fix-tsconfig-outDir branch March 15, 2025 16:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryaemami59 @JoshuaKGoldberg @kirkwaiblinger
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy