Skip to content

feat(eslint-plugin): [naming-convention] add enumMember PascalCase default option #11127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

developer-bandi
Copy link
Contributor

PR Checklist

Overview

add enumMember PascalCase default option

add enumMember PascalCase default option
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 4, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7ae0218
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68755479572a0d0008b4a98a
😎 Deploy Preview https://deploy-preview-11127--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented May 4, 2025

View your CI Pipeline Execution ↗ for commit 7ae0218

Command Status Duration Result
nx run-many -t lint ❌ Failed 3m 11s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 16s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 11s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-14 19:15:08 UTC

Copy link

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (816be17) to head (7ae0218).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11127   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         503      503           
  Lines       51036    51040    +4     
  Branches     8424     8424           
=======================================
+ Hits        46373    46377    +4     
  Misses       4648     4648           
  Partials       15       15           
Flag Coverage Δ
unittest 90.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 97.82% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label May 5, 2025
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label May 6, 2025
@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[naming-convention] enumMembers should be default PascalCase
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy