-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: migrate to pnpm #11248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: migrate to pnpm #11248
Changes from all commits
0b9c67d
d78c30d
e738b1b
8227be7
e1080b5
ae63c55
e4500eb
78f97ca
b2740d3
47bca3f
caae48b
6ff72a1
83ea658
df07c3c
0ffc5cc
feb01b1
9ed6376
a497ac5
351de42
03bd8d3
1de3fca
77ca6dd
644216b
0fe7f92
a6f9007
08f458c
de5ee8b
46e0620
88af74c
7e51137
d064374
8b0b3f5
1f4cdf3
a285fd3
8c0b7a7
319a153
354e19f
7156616
5883023
2bbb8d1
66cf651
cb29a89
ca45552
facb3b4
1eb19aa
178a63d
3cbb725
883d0ea
fbf1124
2f26b78
d301b3f
9370c28
f1ad8b9
635d1ef
caa05cd
4649727
42d001f
9318d86
fe0e30d
7159cac
53f325f
88f10a7
3fc4202
59fefad
5368940
ec4bd4e
7ecfd88
7383a07
f87275a
99086f1
f684ddc
ecc931b
84729ad
855ec1b
547238c
814e5d9
5de32f8
2547549
c172330
9b2dea0
559deed
dc6b52f
6378466
2b44b0a
b9e41de
a3c82cd
fd1df19
d214d1b
50e3938
c123198
aafacea
aa07223
6da2a7a
75e3231
a864d53
253a6b0
dd9d19c
e0f7582
ac83e81
22dc214
80ffa6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
JamesHenry marked this conversation as resolved.
Show resolved
Hide resolved
|
JamesHenry marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -20,24 +20,25 @@ jobs: | |||||
name: Run prettier formatting if required | ||||||
runs-on: ubuntu-latest | ||||||
steps: | ||||||
- uses: actions/checkout@v4 | ||||||
with: | ||||||
ref: ${{ github.event.pull_request.head.ref }} | ||||||
persist-credentials: false | ||||||
|
||||||
- name: Check if prettier was changed as part of the latest commit on the PR | ||||||
id: prettier-package-check | ||||||
run: | | ||||||
git diff HEAD~1 -G"prettier" --exit-code package.json && echo "prettier unchanged" || echo "::set-output name=was-changed::true" | ||||||
|
||||||
- uses: pnpm/action-setup@v4 | ||||||
if: ${{ steps.nrwl-workspace-package-check.outputs.was-changed == 'true' }} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wrong condition ID reference and wrong place in the workflow (per previous comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's also completely unchanged... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok sorry, looks like there was a github caching issue. It is now in the correct place, but the step ID is still wrong
Suggested change
|
||||||
name: Install pnpm | ||||||
with: | ||||||
run_install: false | ||||||
|
||||||
- name: Run prettier formatting if prettier was changed and commit the results | ||||||
if: ${{ steps.prettier-package-check.outputs.was-changed == 'true' }} | ||||||
env: | ||||||
# We cannot use secrets.GITHUB_TOKEN for this because it is not permitted to kick off subsequent actions worfklow runs, so we use a PAT instead | ||||||
GITHUB_TOKEN: ${{ secrets.JAMES_HENRY_GITHUB_TOKEN }} | ||||||
run: | | ||||||
yarn --mode skip-build | ||||||
yarn format | ||||||
pnpm install --ignore-scripts | ||||||
pnpm run format | ||||||
|
||||||
# Commit all the changes to the PR (see note on not being able to use secrets.GITHUB_TOKEN for this) | ||||||
git config --global user.email "james@henry.sc" | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
yarn pre-commit | ||
pnpm run pre-commit |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +0,0 @@ | ||
package-lock=false | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.