Skip to content

fix(project-service): add missing typescript peer dependency #11265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2025
Merged

fix(project-service): add missing typescript peer dependency #11265

merged 1 commit into from
Jun 1, 2025
+5 −0

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jun 1, 2025 •
edited
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JounQin!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 1, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0f78d4d
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/683c33e69f29af000820715c
😎 Deploy Preview https://deploy-preview-11265--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@JounQin JounQin mentioned this pull request Jun 1, 2025
Open
@JounQin JounQin force-pushed the fix/typescript_peer branch from b29a35f to 0f78d4d Compare June 1, 2025 11:05
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 0f78d4d.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 4m 56s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 59s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 18s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 6s View ↗
nx run-many -t lint ✅ Succeeded 10s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx run generate-configs ✅ Succeeded 5s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-01 11:16:06 UTC

@bradzacher bradzacher changed the title fix: typescript should be peer dependency of project-service fix(project-service): add missing typescript peer dependency Jun 1, 2025
bradzacher
bradzacher approved these changes Jun 1, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant - thanks for this

@bradzacher bradzacher enabled auto-merge (squash) June 1, 2025 11:08
@bradzacher bradzacher merged commit 9d46857 into typescript-eslint:main Jun 1, 2025
63 of 67 checks passed
@JounQin JounQin deleted the fix/typescript_peer branch June 1, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: typescript should be peer dependency of project-service
2 participants
@JounQin @bradzacher
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy