Skip to content

chore(eslint-plugin): switch auto-generated test cases to hand-written in no-inferrable-types.test.ts #11275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vinccool96
Copy link
Contributor

PR Checklist

Overview

  • Change dynamic test cases using spread and map to hand-written ones
  • Specify existing recurring cases through comments

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Vinccool96!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f2133e7
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6841fb1018c8b4000804858a
😎 Deploy Preview https://deploy-preview-11275--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Jun 5, 2025

View your CI Pipeline Execution ↗ for commit f2133e7.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 7s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 55s View ↗
nx run-many -t lint ✅ Succeeded 11s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded <1s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded <1s View ↗
nx run generate-configs ✅ Succeeded 4s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-05 20:26:44 UTC

"const a = new RegExp('a');",
// Testing with double quotes
// eslint-disable-next-line @typescript-eslint/internal/plugin-test-formatting
'const a = "str";',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be removed, since the only change with the one below is that it's using double quotes

{
// Testing with double quotes
// eslint-disable-next-line @typescript-eslint/internal/plugin-test-formatting
code: 'const a: string = "str";',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be removed, since the only change with the one below is that it's using double quotes

@Vinccool96 Vinccool96 marked this pull request as ready for review June 5, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: [no-inferrable-types.test.ts] Switch auto-generated test cases to hand-written
1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy