Skip to content

feat(typescript-eslint): support basePath in tseslint.config() #11357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 7, 2025
Merged

feat(typescript-eslint): support basePath in tseslint.config() #11357

merged 8 commits into from
Jul 7, 2025
+76 −2

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Jun 30, 2025 •
edited
Loading

PR Checklist

Overview

Adapts https://github.com/eslint/rewrite/pull/223/files#diff-a42aaf8268f1b91836794b8203043694f266efcd4bc078af6091e13481d3d694 for our config helper.

Co-authored-by: @ntnyq

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 30, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a299f95
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/686bf2921f7b3000084c7ee4
😎 Deploy Preview https://deploy-preview-11357--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 97 (🔴 down 3 from production)
Best Practices: 100 (no change from production)
SEO: 92 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a299f95

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 6s View ↗
nx run-many -t lint ✅ Succeeded 3m 10s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 9s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 9s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-07 16:27:44 UTC

@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (d1388fc) to head (a299f95).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11357   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files         501      501           
  Lines       50978    50987    +9     
  Branches     8407     8410    +3     
=======================================
+ Hits        46315    46324    +9     
  Misses       4648     4648           
  Partials       15       15
Flag Coverage Δ
unittest 90.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-eslint/src/config-helper.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review June 30, 2025 16:39
@kirkwaiblinger kirkwaiblinger requested a review from a team June 30, 2025 21:26
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 30, 2025
bradzacher
bradzacher previously approved these changes Jun 30, 2025
View reviewed changes
bradzacher
bradzacher reviewed Jun 30, 2025
View reviewed changes
packages/typescript-eslint/src/config-helper.ts Outdated
@@ -23,6 +23,11 @@ export type InfiniteDepthConfigWithExtends =
| InfiniteDepthConfigWithExtends[];

export interface ConfigWithExtends extends TSESLint.FlatConfig.Config {
/**
* The base path for files and ignores.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a @since eslint v9.x.y?

@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 30, 2025
@kirkwaiblinger kirkwaiblinger mentioned this pull request Jun 30, 2025
Draft
3 tasks
bradzacher
bradzacher previously approved these changes Jul 1, 2025
View reviewed changes
@ntnyq ntnyq mentioned this pull request Jul 1, 2025
Closed
3 tasks
@kirkwaiblinger
Copy link
Member Author

@ntnyq coming from #11363 (comment) can you give an explanation of why that change should be made? I'm not following.

@kirkwaiblinger
Copy link
Member Author

Thought about it and @ntnyq was right - the basePath property needs to be on the Config type, not the ConfigWithExtends type. Added a commit and co-author attribution

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :)

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 7, 2025
@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) July 7, 2025 16:15
@kirkwaiblinger kirkwaiblinger merged commit 0c40c7a into typescript-eslint:main Jul 7, 2025
59 of 61 checks passed
@kirkwaiblinger kirkwaiblinger deleted the support-base-path branch July 7, 2025 23:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher Awaiting requested review from bradzacher

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Support basePath property in Config of ESLint
3 participants
@kirkwaiblinger @JoshuaKGoldberg @bradzacher
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy