Skip to content

feat: remove deprecated RuleContext types #11386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: remove deprecated RuleContext types #11386

wants to merge 6 commits into from
+0 −34

Conversation

cseas
Copy link
Contributor

@cseas cseas commented Jul 8, 2025

PR Checklist

Overview

Removed deprecated types as mentioned in #11371 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @cseas!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 8, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c047df6
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/686e1ccd33e3fe00083ae64c
😎 Deploy Preview https://deploy-preview-11386--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c047df6

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 4s View ↗
nx run-many -t lint ✅ Succeeded 3m 17s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 9s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 9s View ↗
nx run types:build ✅ Succeeded 4s View ↗
nx run integration-tests:test ✅ Succeeded 4s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-09 07:52:17 UTC

cseas
cseas commented Jul 8, 2025
View reviewed changes
kirkwaiblinger
kirkwaiblinger requested changes Jul 8, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can only remove the 4 methods removed in eslint/eslint#19910.

Others (such as getPhysicalFilename()) may be deprecated but still exist, and are documented at https://eslint.org/docs/latest/extend/custom-rules#the-context-object

@kirkwaiblinger kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Jul 8, 2025
@cseas
Copy link
Contributor Author

cseas commented Jul 9, 2025

Now the PR only removes the 4 methods removed in eslint/eslint#19910

kirkwaiblinger
kirkwaiblinger approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kirkwaiblinger kirkwaiblinger added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting response Issues waiting for a reply from the OP or another party labels Jul 9, 2025
@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Jul 13, 2025
bradzacher
bradzacher approved these changes Jul 13, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good but removing these is a breaking change that will need to wait for the next major

@bradzacher bradzacher added this to the 9.0.0 milestone Jul 13, 2025
@kirkwaiblinger
Copy link
Member

@bradzacher If the methods don't exist at runtime, is it really breaking or fixing?

@bradzacher
Copy link
Member

They do exist if the user is on v8.57.0 - which is the minimum version we support.

Around half of our users are on that version right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge breaking change This change will require a new major version to be released
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Enhancement: Bug: remove typings for context.markVariableAsUsed() and friends?
3 participants
@cseas @kirkwaiblinger @bradzacher
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy