Skip to content

feat(typescript-estree): forbid optional chain in TemplateTaggedLiteral #11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 18, 2025
Merged

feat(typescript-estree): forbid optional chain in TemplateTaggedLiteral #11391

merged 9 commits into from
Jul 18, 2025
+68 −1

Conversation

asdf93074
Copy link
Contributor

PR Checklist

Overview

Title. Do guide me if I'm missing things, not super familiar with the codebase.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @asdf93074!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 10, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 64e3ba9
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6878d8227df62800083aad2b
😎 Deploy Preview https://deploy-preview-11391--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 64e3ba9

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 22s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 16s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 11s View ↗
nx run types:build ✅ Succeeded 4s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-17 11:13:22 UTC

@asdf93074 asdf93074 changed the title feat(11352): forbid optional chain in TemplateTaggedLiteral. feat(typescript-estree): forbid optional chain in TemplateTaggedLiteral. Jul 10, 2025
@asdf93074 asdf93074 changed the title feat(typescript-estree): forbid optional chain in TemplateTaggedLiteral. feat(typescript-estree): forbid optional chain in TemplateTaggedLiteral Jul 10, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.85%. Comparing base (0e884c7) to head (64e3ba9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 0.00% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11391      +/-   ##
==========================================
- Coverage   90.86%   90.85%   -0.02%     
==========================================
  Files         503      503              
  Lines       51037    51044       +7     
  Branches     8424     8424              
==========================================
  Hits        46374    46374              
- Misses       4648     4655       +7     
  Partials       15       15
Flag Coverage Δ
unittest 90.85% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert.ts 30.20% <0.00%> (-0.07%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bradzacher
bradzacher requested changes Jul 13, 2025
View reviewed changes
asdf93074
asdf93074 commented Jul 14, 2025
View reviewed changes
bradzacher
bradzacher requested changes Jul 15, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last change and we're good!

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jul 15, 2025
@asdf93074
Copy link
Contributor Author

Is this test flaky? https://github.com/typescript-eslint/typescript-eslint/actions/runs/16300086081/job/46032242502

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jul 18, 2025
@bradzacher bradzacher self-requested a review July 18, 2025 13:06
bradzacher
bradzacher approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant thanks!

@bradzacher bradzacher merged commit f08d08f into typescript-eslint:main Jul 18, 2025
62 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Forbid optional chaining in TaggedTemplateExpression
2 participants
@asdf93074 @bradzacher
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy