Skip to content

fix: disallow extra properties in rule options #11397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: disallow extra properties in rule options #11397

wants to merge 3 commits into from
+4 −2

Conversation

andreww2012
Copy link

@andreww2012 andreww2012 commented Jul 14, 2025 •
edited
Loading

PR Checklist

Overview

This PR simply disallows extra properties in rules' schemas which currently allow them.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @andreww2012!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 14, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4ba7bb5
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6876ad576c893e00088b684c
😎 Deploy Preview https://deploy-preview-11397--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 14, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4ba7bb5

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 23s View ↗
nx run types:build ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-18 11:24:51 UTC

@andreww2012
Copy link
Author

I followed "Updating Snapshots" section in the contributing guide, but running yarn test schemas -u failed with "NX Cannot find project 'schemas'" error for me. I had to use npx vitest -u tests/schemas.test.ts from the same directory.

@codecov Codecov
Copy link

codecov bot commented Jul 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (16c344e) to head (4ba7bb5).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11397   +/-   ##
=======================================
  Coverage   90.85%   90.86%           
=======================================
  Files         501      503    +2     
  Lines       50987    51038   +51     
  Branches     8410     8424   +14     
=======================================
+ Hits        46324    46375   +51     
  Misses       4648     4648           
  Partials       15       15
Flag Coverage Δ
unittest 90.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/eslint-plugin/src/rules/prefer-destructuring.ts 100.00% <100.00%> (ø)
...lint-plugin/src/rules/prefer-nullish-coalescing.ts 98.27% <100.00%> (+<0.01%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger marked this pull request as draft July 14, 2025 16:12
@andreww2012 andreww2012 marked this pull request as ready for review July 17, 2025 08:26
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒 thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreww2012 @JoshuaKGoldberg
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy