fix(typescript-eslint): tolerate spaces and other path cases in inferred tsconfigRootDir paths #11408
Conversation
…est.ts Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 22fc507
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11408 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 503 503
Lines 51037 51029 -8
Branches 8424 8418 -6
=======================================
- Hits 46374 46367 -7
Misses 4648 4648
+ Partials 15 14 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| @@ -2,7 +2,10 @@ import { fileURLToPath } from 'node:url'; | |||
|
|
|||
| export function getTSConfigRootDirFromStack(stack: string): string | undefined { | |||
| for (const line of stack.split('\n').map(line => line.trim())) { | |||
| const candidate = /(\S+)eslint\.config\.(c|m)?(j|t)s/.exec(line)?.[1]; | |||
| const candidate = /(.+?)[/\\]+eslint\.config\.(c|m)?(j|t)s/ | |||
PR Checklist
Overview
This is a bit of a band-aid fix: it makes the original regular expression allow spaces, then manually removes the
atorat asyncfrom the line. I think a better long-term strategy would be to go with what @kirkwaiblinger suggested of a more formal error stack trace parser. But I'd really like to get this fixed ASAP.Note that this mostly only conflicts with #11406 in terms of lines touched. We should be able to merge one after the other with minimal conflict resolution.
💖
Co-authored-by: @kirkwaiblinger