Skip to content

fix: normalize tsconfigRootDir to handle trailing path separators in project: true #11419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ export function getProjectConfigFiles(
let directory = path.dirname(parseSettings.filePath);
const checkedDirectories = [directory];

// Normalize tsconfigRootDir once to avoid repeated regex operations in the loop
const normalizedTsconfigRootDirLength = Math.max(
1,
parseSettings.tsconfigRootDir.replace(/[/\\]+$/, '').length,
);

do {
log('Checking tsconfig.json path: %s', directory);
const tsconfigPath = path.join(directory, 'tsconfig.json');
Expand All @@ -57,7 +63,7 @@ export function getProjectConfigFiles(
checkedDirectories.push(directory);
} while (
directory.length > 1 &&
directory.length >= parseSettings.tsconfigRootDir.length
directory.length >= normalizedTsconfigRootDirLength
);

throw new Error(
Expand Down
15 changes: 15 additions & 0 deletions packages/typescript-estree/tests/lib/getProjectConfigFiles.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -178,5 +178,20 @@ describe(getProjectConfigFiles, () => {
`[Error: project was set to \`true\` but couldn't find any tsconfig.json relative to './repos/repo/packages/package/file.ts' within '/'.]`,
);
});

it('works correctly with trailing path separator in tsconfigRootDir', () => {
mockExistsSync.mockImplementation(
filePath => filePath === path.normalize('repos/repo/tsconfig.json'),
);

const actual = getProjectConfigFiles(
{ ...parseSettings, tsconfigRootDir: './repos/repo/' },
true,
);

expect(actual).toStrictEqual([
path.normalize('repos/repo/tsconfig.json'),
]);
});
});
});
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy