Skip to content

feat(eslint-plugin): support explicit resource management with await #11426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat(eslint-plugin): support explicit resource management with await #11426

wants to merge 2 commits into from
+19 −1

Conversation

ahmedsalman74
Copy link

@ahmedsalman74 ahmedsalman74 commented Jul 26, 2025 •
edited
Loading

… using`

  • Update rule logic to recognize await using as a valid await expression
  • Add tests to ensure async functions with await using are not reported
  • Aligns with ESLint v9.32.0 behavior and supports new ECMAScript syntax

PR Checklist

Overview

@ahmedsalman74
feat(require-await): support explicit resource management with `await…
836c893 
… using`

- Update rule logic to recognize `await using` as a valid await expression
- Add tests to ensure async functions with `await using` are not reported
- Aligns with ESLint v9.32.0 behavior and supports new ECMAScript syntax
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ahmedsalman74!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 26, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 31db587
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68853e4a0995cd0008619fdd
😎 Deploy Preview https://deploy-preview-11426--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 26, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 31db587

Command Status Duration Result
nx run ast-spec:test -- --coverage ❌ Failed 13s View ↗
nx test ast-spec ❌ Failed 10s View ↗
nx run-many -t lint ✅ Succeeded 3m 17s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 2s View ↗
nx run integration-tests:test ✅ Succeeded 52s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
Additional runs (11) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-26 20:50:27 UTC

@ahmedsalman74
fix(integration-tests): filter out @stylistic/eslint-plugin startup m…
31db587 
…essage from stderr in integration test assertion

This prevents expected plugin info/warning output from causing test failures, ensuring only real errors fail the test.
@ahmedsalman74 ahmedsalman74 changed the title feat(require-await): support explicit resource management with `await… feat(eslint-plugin): support explicit resource management with await Jul 26, 2025
@bradzacher
Copy link
Member

This PR was clearly built using AI and I don't think you reviewed the output either -- this is what we would class as "AI slop".

  • It has made an unnecessary change to a completely unrelated file
  • The PR description just literally explains the changes that were done
  • The PR description does not match our template or contributor guidelines
  • It has added tests for cases that already had test cases and makes no other changes -- and reviewing the changes would have highlighted that this was already implemented.

We're happy if you use AI but you need to review the changes instead of just blindly vibe coding

@bradzacher bradzacher closed this Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmedsalman74 @bradzacher
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy