Skip to content

chore: upgrade @prettier/sync to fix CI lint failures #11439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Jul 31, 2025

PR Checklist

Overview

Seems like the failure has to do with some performance-y problems in make-synchronized. Upgrading @prettier/sync may solve this (since it uses a more recent version of make-synchronized) 🤷

Locally, I haven't been able to reproduce the failure with this commit

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 31, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 512f92e
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/688ba93c12cdcd00085a7695
😎 Deploy Preview https://deploy-preview-11439--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Jul 31, 2025

View your CI Pipeline Execution ↗ for commit 512f92e

Command Status Duration Result
nx run integration-tests:test ❌ Failed 50s View ↗
nx run ast-spec:test -- --coverage ❌ Failed 12s View ↗
nx run-many -t lint ✅ Succeeded 3m 19s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 4s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 9s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 9s View ↗
Additional runs (17) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-31 17:40:48 UTC

@kirkwaiblinger kirkwaiblinger changed the title chore: upgrade @prettier/sync chore: upgrade @prettier/sync to fix CI lint failures Jul 31, 2025
@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review July 31, 2025 17:41
@bradzacher bradzacher merged commit 9232c0c into typescript-eslint:main Jul 31, 2025
41 of 68 checks passed
@kirkwaiblinger kirkwaiblinger deleted the upgrade-prettier-sync branch July 31, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Lint CI task failing on main (and PR branches)
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy