Skip to content

feat: update to TypeScript 5.9.2 #11445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2025
Merged

feat: update to TypeScript 5.9.2 #11445

merged 2 commits into from
Aug 3, 2025
+305 −84

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

This PR bumps the dependency version and regenerates the lib defs.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 2, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 42911d9
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/688ea8e2f351c00008c3a093
😎 Deploy Preview https://deploy-preview-11445--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 79 (🔴 down 19 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 2, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 42911d9

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 19s View ↗
nx run-many -t lint ✅ Succeeded 3m 20s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 19s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 9s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-03 00:21:19 UTC

@bradzacher bradzacher force-pushed the bjz/typescript-5-9-lib branch from 30a760d to 799d99c Compare August 2, 2025 02:31
@codecov Codecov
Copy link

codecov bot commented Aug 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (b872e2b) to head (42911d9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11445      +/-   ##
==========================================
+ Coverage   90.86%   90.88%   +0.01%     
==========================================
  Files         503      505       +2     
  Lines       51052    51124      +72     
  Branches     8416     8416              
==========================================
+ Hits        46390    46462      +72     
  Misses       4648     4648              
  Partials       14       14
Flag Coverage Δ
unittest 90.88% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/scope-manager/src/lib/dom.iterable.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/dom.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/esnext.error.ts 100.00% <100.00%> (ø)
...kages/scope-manager/src/lib/esnext.sharedmemory.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/esnext.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/index.ts 100.00% <100.00%> (ø)
...ckages/scope-manager/src/lib/webworker.iterable.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/webworker.ts 100.00% <100.00%> (ø)
packages/typescript-estree/src/convert.ts 30.20% <ø> (ø)
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts 97.50% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sdavids
sdavids reviewed Aug 2, 2025
View reviewed changes
package.json
@@ -98,7 +98,7 @@
"rimraf": "^5.0.5",
"semver": "7.7.0",
"tsx": "*",
"typescript": ">=4.8.4 <5.9.0",
"typescript": ">=4.8.4 <6.0.0",
Copy link

@sdavids sdavids Aug 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could be more conservative here (and in other places) and use <5.10.0.

https://devblogs.microsoft.com/typescript/announcing-typescript-5-9/#what’s-next

Now that TypeScript 5.9 is out [...] next version: TypeScript 6.0.

They might change their mind though and add 5.10 in between …

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript versioning works this way.
They will not do a 5.10 release - only a 6.0

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also this PR; microsoft/TypeScript#62162

kirkwaiblinger
kirkwaiblinger reviewed Aug 2, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter failure appears to be legitimate, but otherwise LGTM

@bradzacher bradzacher enabled auto-merge (squash) August 3, 2025 00:10
@aaylward aaylward mentioned this pull request Aug 3, 2025
Open
kirkwaiblinger
kirkwaiblinger approved these changes Aug 3, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@bradzacher bradzacher merged commit 2112d58 into main Aug 3, 2025
65 checks passed
@bradzacher bradzacher deleted the bjz/typescript-5-9-lib branch August 3, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdavids sdavids sdavids left review comments

@WikiRik WikiRik WikiRik left review comments

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bradzacher @sdavids @WikiRik @kirkwaiblinger
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy