Skip to content

fix(eslint-plugin): revert #11127 #11447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Aug 3, 2025

PR Checklist

Overview

Reverts #11127 which was a breaking change merged by mistake.

See #7879 (comment)


This reverts commit b872e2b.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 3, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8bc80d3
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/688fb227e91ca200088684de
😎 Deploy Preview https://deploy-preview-11447--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin): Revert #11127 fix(eslint-plugin): revert #11127 Aug 3, 2025
@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) August 3, 2025 19:03
Copy link

nx-cloud bot commented Aug 3, 2025

View your CI Pipeline Execution ↗ for commit 8bc80d3

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 5s View ↗
nx run-many -t lint ✅ Succeeded 3m 22s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 21s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 4s View ↗
nx run integration-tests:test ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-03 19:12:45 UTC

@kirkwaiblinger kirkwaiblinger requested a review from a team August 3, 2025 19:21
@kirkwaiblinger kirkwaiblinger merged commit e901ad8 into typescript-eslint:main Aug 4, 2025
71 of 72 checks passed
@kirkwaiblinger kirkwaiblinger deleted the revert-naming-convention-break branch August 4, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy