Skip to content

chore: update eslint-plugin-eslint-plugin #11449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2025
Merged

chore: update eslint-plugin-eslint-plugin #11449

merged 2 commits into from
Aug 9, 2025
+12 −41

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Aug 4, 2025

Updates the the new major which is ESM only, flat-configs only, and has
its own types!

I didn't make any issue for this since its a basic devDependency upgrade.

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 4, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1ae93fb
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6896b44b0a6c49000860c1b5
😎 Deploy Preview https://deploy-preview-11449--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@43081j 43081j marked this pull request as draft August 4, 2025 16:13
@43081j
Copy link
Contributor Author

43081j commented Aug 4, 2025

i'm marking it as a draft since i didn't make an issue yet

let me know if you want one, or we can just mark as ready to review

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 1ae93fb

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 17s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 15s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-09 02:42:57 UTC

@43081j
chore: update eslint-plugin-eslint-plugin
207d006 
Updates the the new major which is ESM only, flat-configs only, and has
its own types!
@kirkwaiblinger
Copy link
Member

I think it makes sense to go ahead with this PR (especially in light of #11470 blocking us from getting normal renovate PRs for dependency updates). thanks!

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review August 9, 2025 02:36
@codecov Codecov
Copy link

codecov bot commented Aug 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (7319bad) to head (1ae93fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11449      +/-   ##
==========================================
- Coverage   90.88%   90.87%   -0.01%     
==========================================
  Files         505      505              
  Lines       51125    51117       -8     
  Branches     8415     8415              
==========================================
- Hits        46463    46455       -8     
  Misses       4648     4648              
  Partials       14       14
Flag Coverage Δ
unittest 90.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts 100.00% <ø> (ø)
.../eslint-plugin/src/rules/class-methods-use-this.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts 99.20% <ø> (-0.04%) ⬇️
...t-plugin/src/rules/no-meaningless-void-operator.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) August 9, 2025 02:37
@kirkwaiblinger kirkwaiblinger merged commit fee2bc6 into typescript-eslint:main Aug 9, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@43081j @kirkwaiblinger
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy