fix(utils): correct calculateConfigForFile return type
#11451
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Issue: typescript-eslint#11444 Changes: - Extend `FlatESLintBase` generic with `FlatConfig.Config` - Update `calculateConfigForFile` to return `FlatConfig.Config` Note: The comment for `calculateConfigForFile` in `FlatESLintBase` mentions the return type as "A configuration object for the file or `undefined` if there is no configuration data". This differs from the base `SharedESLintBase`, which only states it returns the config object. Left as-is, but may warrant clarification or further typing updates.
|
Thanks for the PR, @Gajdascz! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit b2d14c9
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Changes:
FlatESLintBasegeneric withFlatConfig.ConfigcalculateConfigForFileto returnFlatConfig.ConfigNotes:
The comment for
calculateConfigForFileinFlatESLintBasementions it may returnundefinedif no config is available, which differs from the baseSharedESLintBase, which does not mentionundefined.I've preserved the comment and focused solely on aligning the return type with
FlatConfig.Config. If you'd like this potential discrepancy explored or clarified further, I'm happy to look into it and follow up with additional typing or doc updates in this PR or a separate one.