Skip to content

Remove problematic newline in lint unboundWithoutThisAnnotation message #11458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zsiegel92
Copy link

Newlines in lint issue messages interfere with scripts that count occurrences of errors/warnings with unix coreutils.

This PR does not meet the PR checklist but it's very minor and self-evidently useful.

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @zsiegel92!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 5, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3f280f7
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/689209c414cf53000841fd43
😎 Deploy Preview https://deploy-preview-11458--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Aug 5, 2025

View your CI Pipeline Execution ↗ for commit 3f280f7

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 14s View ↗
nx run-many -t lint ✅ Succeeded 3m 23s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 14s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-05 13:51:40 UTC

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (88b063e) to head (3f280f7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11458   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files         505      505           
  Lines       51121    51121           
  Branches     8413     8413           
=======================================
  Hits        46459    46459           
  Misses       4648     4648           
  Partials       14       14           
Flag Coverage Δ
unittest 90.88% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/unbound-method.ts 99.07% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy