Skip to content

feat(eslint-plugin): add no-throw-literal [extension] #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 20, 2019
Merged

feat(eslint-plugin): add no-throw-literal [extension] #1331

merged 6 commits into from
Dec 20, 2019

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1258

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement: new plugin rule New rule request for eslint-plugin label Dec 14, 2019
@a-tarasyuk a-tarasyuk force-pushed the feature/no-throw-literal branch 4 times, most recently from 615df96 to aa79d6e Compare December 14, 2019 18:03
@a-tarasyuk a-tarasyuk force-pushed the feature/no-throw-literal branch from aa79d6e to 9dc6da0 Compare December 14, 2019 20:51
@a-tarasyuk a-tarasyuk marked this pull request as ready for review December 14, 2019 22:47
bradzacher
bradzacher requested changes Dec 19, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM - a few comments.
Thanks for doing this

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Dec 19, 2019
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 19, 2019
bradzacher
bradzacher approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this!

@bradzacher bradzacher changed the title feat(eslint-plugin): add no-throw-literal feat(eslint-plugin): add no-throw-literal [extension] Dec 20, 2019
@bradzacher bradzacher merged commit 2aa696c into typescript-eslint:master Dec 20, 2019
@bajtos bajtos mentioned this pull request Jan 10, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Closed
This was referenced Jan 24, 2020
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-throw-literal] Resolve ESLint known limitations
2 participants
@a-tarasyuk @bradzacher
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy