Skip to content

test(typescript-estree): Update alignment tests #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 17, 2019
Merged

test(typescript-estree): Update alignment tests #1343

merged 5 commits into from
Dec 17, 2019

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Dec 16, 2019

  • removes legacy package babel-code-frame and replaces it with @babel/code-frame
  • update @babel/parser to latest version
  • enable some of alignment tests
  • update alignment issue messages about optional chaining and declare class properties

@armano2 armano2 self-assigned this Dec 16, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 added the package: typescript-estree Issues related to @typescript-eslint/typescript-estree label Dec 16, 2019
@armano2 armano2 removed their assignment Dec 16, 2019
@armano2 armano2 added tests anything to do with testing dependencies Issue about dependencies of the package labels Dec 16, 2019
armano2
armano2 commented Dec 16, 2019
View reviewed changes
packages/typescript-estree/tests/ast-alignment/parse.ts
error.codeFrame = codeFrame(text, loc.line, loc.column + 1, {
highlightCode: true,
});
error.codeFrame = codeFrameColumns(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeFrame with line and column parameters got deprecated and replaced with codeFrameColumns

@armano2 armano2 changed the title test(typescript-estree): Update alignment testsEstree tests test(typescript-estree): Update alignment tests Dec 17, 2019
bradzacher
bradzacher approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bradzacher bradzacher merged commit 5c096de into typescript-eslint:master Dec 17, 2019
@armano2 armano2 deleted the estree-tests branch December 17, 2019 01:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package package: typescript-estree Issues related to @typescript-eslint/typescript-estree tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy