Skip to content

chore: remove redundant lerna:init script #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Mar 3, 2021

Remove double yarn install run, lerna bootstrap is not recommended when yarn workspaces are used, this setp was redundant.

this change introduce small perf to ci build time ~-5s per job

ref: lerna/lerna#1308, lerna/lerna#2352

@armano2 armano2 added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Mar 3, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher
Copy link
Member

This also gets rid both bootstrap and link - is that correct?
Are you sure we don't need either of these steps with yarn workspaces?

I vaguely remember having some weirdness with local package linking without it.

@armano2
Copy link
Collaborator Author

armano2 commented Mar 3, 2021

This also gets rid both bootstrap and link - is that correct?
Are you sure we don't need either of these steps with yarn workspaces?

I vaguely remember having some weirdness with local package linking without it.

yes that was my intention as both of them are not suppose to be used with yarn worksapces

lerna bootstrap in esence runs yarn install in root directory
lerna link runs executes yarn link between packages - this step is done by workspaces already


generally we don't really need lerna (except release) as everything else can be done with yarn commands, but this is different topic

yarn workspaces run build
yarn workspace <workspace_name> run build

@bradzacher bradzacher merged commit a642290 into master Mar 5, 2021
@bradzacher bradzacher deleted the chore/lerna-init branch March 5, 2021 17:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy